Differential D24432

Fix crash when lauching dolphin with a search scheme
ClosedPublic
Actions

Authored by iasensio on Oct 5 2019, 11:13 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Dolphin
Commits
R318:fcf2d98447a1: Merge branch 'Applications/19.08'
R318:31fd775f368f: Fix crash when lauching dolphin with a search scheme
Summary

Widget objects are initialized in DolphinSearchBox::init(), which is called on QEvent::Polish, so we must set it visible before calling fromSearchUrl.

Test Plan

dolphin --new-window baloosearch://

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
iasensio created this revision.Oct 5 2019, 11:13 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptOct 5 2019, 11:13 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
iasensio requested review of this revision.Oct 5 2019, 11:13 PM
elvisangelaccio accepted this revision.Oct 6 2019, 9:39 AM
This revision is now accepted and ready to land.Oct 6 2019, 9:39 AM
Closed by commit R318:31fd775f368f: Fix crash when lauching dolphin with a search scheme (authored by iasensio, committed by elvisangelaccio). · Explain WhyOct 6 2019, 9:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/dolphinviewcontainer.cpp (6 lines)

Diff 67365

View Options

src/dolphinviewcontainer.cpp

Loading...