Differential D24429

[ConfigModule] Expose mainUi component status and error string
ClosedPublic
Actions

Authored by broulik on Oct 5 2019, 7:00 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R295:8cea2dacd805: [KCModuleLoader] Show error when QML fails to load
R296:2c2942cee9ec: [ConfigModule] Expose mainUi component status and error string

Diff Detail

Repository
R296 KDeclarative
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Oct 5 2019, 7:00 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 5 2019, 7:00 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Oct 5 2019, 7:00 PM
broulik added a dependent revision: D24430: [KCModuleLoader] Show error when QML fails to load.
ngraham added a subscriber: ngraham.Oct 6 2019, 3:57 PM

Is the text in the window mouse-selectable? That would be really nice.

broulik added a comment.Oct 7 2019, 9:41 AM

Is the text in the window mouse-selectable?

I don't think so (didn't test, just read the code) but should be trivial to add.

mart accepted this revision.Oct 8 2019, 11:34 AM
This revision is now accepted and ready to land.Oct 8 2019, 11:34 AM
Closed by commit R296:2c2942cee9ec: [ConfigModule] Expose mainUi component status and error string (authored by broulik). · Explain WhyOct 8 2019, 12:39 PM
This revision was automatically updated to reflect the committed changes.
kossebau added a subscriber: kossebau.Oct 11 2019, 11:10 AM

Seems this broke the windows build on CI for some reason, please have a look:
https://build.kde.org/view/Failing/job/Frameworks/job/kcmutils/job/kf5-qt5%20WindowsMSVCQt5.13/17/

Revision Contents
Changeset List

Diff 67355

View Options

src/quickaddons/configmodule.h

Loading...
View Options

src/quickaddons/configmodule.cpp

Loading...