Differential D24409

Remove kf5-toys.directory because it will not be used by other packages
ClosedPublic
Actions

Authored by guoyunhe on Oct 4 2019, 10:22 AM.

Details

Reviewers
ngraham
Group Reviewers
Plasma: Workspaces
Commits
R120:a4d6c8c02a5e: Remove kf5-toys.directory because it will not be used by other packages
Summary

See also D24384

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
guoyunhe created this revision.Oct 4 2019, 10:22 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 4 2019, 10:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
guoyunhe requested review of this revision.Oct 4 2019, 10:22 AM
davidedmundson added a subscriber: davidedmundson.Oct 4 2019, 10:24 AM

Ship it (if and only if the other patch is also accepted)

guoyunhe added subscribers: ngraham, aacid.Oct 4 2019, 10:26 AM
In D24409#541894, @davidedmundson wrote:

Ship it (if and only if the other patch is also accepted)

The other patch is accepted by @ngraham . But @aacid has different opinion. I am waiting for his final confirmation or others can give additional reviews.

guoyunhe added a comment.Oct 5 2019, 12:21 PM

D24384 has been accepted and seems no one strongly against it... So I landed it. Can you give this patch an approval? @davidedmundson

ngraham accepted this revision.Oct 5 2019, 1:40 PM
This revision is now accepted and ready to land.Oct 5 2019, 1:40 PM
Closed by commit R120:a4d6c8c02a5e: Remove kf5-toys.directory because it will not be used by other packages (authored by Guo Yunhe <i@guoyunhe.me>). · Explain WhyOct 5 2019, 2:04 PM
This revision was automatically updated to reflect the committed changes.
ltoscano added a subscriber: ltoscano.Oct 5 2019, 2:16 PM

I think you need to bump the dependency on the newer KService, which means the dependency on the newest (right now unreleased) Frameworks.
If I am correct, can you please revert this and push it again when the Plasma team decides to bump the dependency?

Revision Contents
Changeset List

Diff 67346

View Options

menu/desktop/CMakeLists.txt

Loading...
View Options

menu/desktop/kf5-toys.directory

Loading...