Differential D24408

Use the right icon depending on the layout
ClosedPublic
Actions

Authored by apol on Oct 4 2019, 1:48 AM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R119:f9fef4eb5c8f: Use the right icon depending on the layout
Summary

If we're showing the icons in a horizontal layout, the < and > buttons feel like it should be selecting instead of switching pages.

Test Plan

Tested locally

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17317
Build 17335: arc lint + arc unit
apol created this revision.Oct 4 2019, 1:48 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 4 2019, 1:48 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Oct 4 2019, 1:48 AM
ngraham added a subscriber: ngraham.Oct 4 2019, 3:20 AM

Can you share some screenshots? Based on the code I would expect the opposite arrows, but I'm not familiar with this UI.

apol edited the test plan for this revision. (Show Details)Oct 4 2019, 11:10 AM
ngraham accepted this revision.Oct 4 2019, 11:43 AM
This revision is now accepted and ready to land.Oct 4 2019, 11:43 AM
Closed by commit R119:f9fef4eb5c8f: Use the right icon depending on the layout (authored by apol). · Explain WhyOct 4 2019, 2:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 67296

View Options

applets/kimpanel/package/contents/ui/InputPanel.qml

Loading...