Differential D24402

[PlasmaComponents3] Fix checkable toolbutton background
ClosedPublic
Actions

Authored by ngraham on Oct 3 2019, 9:53 PM.

Details

Reviewers

mart

Group Reviewers

Plasma

Commits

R242:949a26d3fa0c: [PlasmaComponents3] Fix checkable toolbutton background

Summary

This fixed the background of a checkable PC3 ToolButton not being visible when checked.
The PC3 Button and PC2 ToolButton did not suffer from the issue, but the PC3 one did.

Test Plan

Checkable PC3 ToolButtons now look checked when checked

No change for non-checkable PC3 ToolButtons

Diff Detail

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ngraham created this revision.Oct 3 2019, 9:53 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptOct 3 2019, 9:53 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

ngraham requested review of this revision.Oct 3 2019, 9:53 PM

Harbormaster completed remote builds in B17309: Diff 67287.Oct 3 2019, 9:53 PM

ngraham added a dependent revision: D24407: Increase UI commonality between KCM and applet.Oct 3 2019, 10:13 PM

mart accepted this revision.Oct 7 2019, 1:25 PM

This revision is now accepted and ready to land.Oct 7 2019, 1:25 PM

Closed by commit R242:949a26d3fa0c: [PlasmaComponents3] Fix checkable toolbutton background (authored by ngraham). · Explain WhyOct 7 2019, 1:29 PM

This revision was automatically updated to reflect the committed changes.

ngraham mentioned this in D24407: Increase UI commonality between KCM and applet.Oct 10 2019, 2:28 PM

ngraham mentioned this in T11558: kill plasma components in favour of qqc2-desktop-style.Oct 21 2019, 6:22 PM

Revision Contents
Changeset List

			Path	Packages
M			src/declarativeimports/plasmacomponents3/ToolButton.qml (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	67287	982c052		Oct 3 2019, 9:53 PM	★	★
Diff 2	67432	04c8eca	R242:949a26d3fa0cfa4993a519486dd07bd0f9901a38	Oct 7 2019, 1:26 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
2e245696dbfc	1bd90843b1cf	982c0520252b	Nate Graham	[PlasmaComponents3] Fix checkable toolbutton background (Show More…)	Oct 3 2019, 9:52 PM

	Status	Author	Revision
	Closed	ngraham	D24407 Increase UI commonality between KCM and applet
	Closed	ngraham	D24402 [PlasmaComponents3] Fix checkable toolbutton background

Diff 67432

View Options

src/declarativeimports/plasmacomponents3/ToolButton.qml