Differential D24401

Use exposed DBus methods to switch activities in CLI
ClosedPublic
Actions

Authored by muesli on Oct 3 2019, 8:01 PM.

Details

Reviewers
ivan
Commits
R6:a1c973c01ece: Use exposed DBus methods to switch activities in CLI
Summary

Since https://phabricator.kde.org/D22381 has landed kactivitymanagerd
now exposes methods to switch to the previous/next activity via DBus.

We can call them from kactivities-cli and remove some duplicated code.

Diff Detail

Repository
R6 KActivities
Branch
cli-nextprev-activity (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17308
Build 17326: arc lint + arc unit
muesli created this revision.Oct 3 2019, 8:01 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 3 2019, 8:01 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
muesli requested review of this revision.Oct 3 2019, 8:01 PM
muesli added a comment.Oct 3 2019, 8:02 PM

Careful: we must _not_ land this before the next Plasma release.

muesli added a comment.Jan 11 2020, 6:11 PM

@ivan Do you think we can merge this now?

muesli added a comment.Jan 13 2020, 3:27 PM

Actually I'm mistaken, we can't merge this just yet. We'll still need to wait for the Plasma 5.18 release.

ngraham added a subscriber: ngraham.Jan 13 2020, 3:28 PM

Yep. This is an odd case of a framework depending on Plasma, not the more typical reverse!

muesli added a comment.Feb 11 2020, 9:54 PM

@ivan @ngraham Ok, with 5.18 out I think we can finally review this one :-)

ivan accepted this revision.Feb 16 2020, 8:08 AM
This revision is now accepted and ready to land.Feb 16 2020, 8:08 AM
Closed by commit R6:a1c973c01ece: Use exposed DBus methods to switch activities in CLI (authored by muesli). · Explain WhyFeb 16 2020, 3:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/cli/main.cpp (26 lines)
Msrc/lib/controller.h (10 lines)
Msrc/lib/controller.cpp (18 lines)

Diff 67281

View Options

src/cli/main.cpp

Loading...
View Options

src/lib/controller.h

Loading...
View Options

src/lib/controller.cpp

Loading...