msec is qint64 and pretty sure the biggest qint64 / 3600000 still doesn't fit in an integer
Details
Details
- Reviewers
- None
Diff Detail
Diff Detail
- Repository
- R244 KCoreAddons
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 17307 Build 17325: arc lint + arc unit
src/lib/util/kformatprivate.cpp | ||
---|---|---|
339 | sorry i just realized ms is quint64, so yes sshould b quint64 |
Comment Actions
Meh, just realized this patch is useless since we end up passing the quint variable to formatSingleDuration that passes it to QObject::tr and that one only supports int, so at some point there's a potential loss of range anyway