Details
Diff Detail
- Repository
- R14 KReport
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Good. Some notes.
| src/renderer/KoReportPreRenderer.cpp | ||
|---|---|---|
| 508–509 | qobject_cast is not an OOP and here it's easy to fix: I would prefer to handle connection in the opposite way: export KRScriptHandler, have it accesible for Kexi's KRScriptFunctions, where we can perform connection to groupChanged(). Note that KoReportPreRenderer.h is exported and it includes krscripthandler.h already, so we miss KREPORT_EXPORT in krscripthandler.h anyway. | |
| src/renderer/scripting/krscripthandler.cpp | ||
| 161 | @todo KEXI3 | |
| src/renderer/scripting/krscripthandler.h | ||
| 87 | @todo KEXI3 | |
@adam I'll push this code (with minimal proposed fixes). W need the kexi-frameworks9-staniek branch in a compleable state because merge with master is close.
| src/renderer/KoReportPreRenderer.cpp | ||
|---|---|---|
| 508–509 | Done: added groupChanged(QMap<QString, QVariant>) signal to the prerenderer. The script handler's signal of the same signature calls it. Kexi connects to prerender's groupChange(), works. Connecting to script handler's groupChange() wouldn't work since handler is created later - inside of generate(). | |