Differential D24395

Add some std::move in setter functions
ClosedPublic
Actions

Authored by aacid on Oct 3 2019, 5:12 PM.

Details

Reviewers
leinir
Commits
R235:1c8d9beb720f: Add some std::move in setter functions
Summary

typically we pass the param as const &, but here we forgot, we can fix
that problem by adding an std::move and have a very similar effect to if
we had declared the params as const &

Diff Detail

Repository
R235 Attica
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Oct 3 2019, 5:12 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 3 2019, 5:12 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Oct 3 2019, 5:12 PM
leinir accepted this revision.Oct 3 2019, 5:14 PM
leinir added a subscriber: leinir.

Looks good :) If you could pop in a TODO KF6 comment, so it's not forgotten when we can, in fact, fix it properly, that'd be great :)

This revision is now accepted and ready to land.Oct 3 2019, 5:14 PM
Closed by commit R235:1c8d9beb720f: Add some std::move in setter functions (authored by aacid). · Explain WhyOct 7 2019, 9:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/comment.cpp (2 lines)
Msrc/content.cpp (4 lines)
Msrc/forum.cpp (2 lines)
Msrc/knowledgebaseentry.cpp (2 lines)

Diff 67469

View Options

src/comment.cpp

Loading...
View Options

src/content.cpp

Loading...
View Options

src/forum.cpp

Loading...
View Options

src/knowledgebaseentry.cpp

Loading...