Differential D24394

Expose the settings object to QML
ClosedPublic
Actions

Authored by ervin on Oct 3 2019, 4:10 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R119:bb2b300addfb: Expose the settings object to QML
Summary

This simplifies quite a bit the logic, we don't need to do the
bookkeeping ourselves anymore. Only missing would be a "isDirty" flag on
the settings object which explains the m_currentTheme member variable
which is still around to have something to compare against in
updateNeedsSave().

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin created this revision.Oct 3 2019, 4:10 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 3 2019, 4:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ervin requested review of this revision.Oct 3 2019, 4:10 PM
mart added inline comments.Oct 3 2019, 4:35 PM
kcms/desktoptheme/kcm.h
48

generic api musings:
could this be upstreamed into ConfigModule directly? (since can't be a virtual, a protected setter?)

ervin added a comment.Oct 4 2019, 7:04 AM
This comment was removed by ervin.
ervin added inline comments.Oct 4 2019, 7:05 AM
kcms/desktoptheme/kcm.h
48

Yes, I got something like that in mind down the line. It's a bit early though, I'd like to see first how the changes in KConfig will impact the logic in here.

ervin updated this revision to Diff 67303.Oct 4 2019, 8:16 AM

Add missing copyright header change

mart accepted this revision.Oct 4 2019, 8:17 AM
This revision is now accepted and ready to land.Oct 4 2019, 8:17 AM
Closed by commit R119:bb2b300addfb: Expose the settings object to QML (authored by ervin). · Explain WhyOct 4 2019, 8:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 67308

View Options

kcms/desktoptheme/kcm.h

Loading...
View Options

kcms/desktoptheme/kcm.cpp

Loading...
View Options

kcms/desktoptheme/package/contents/ui/main.qml

Loading...