Turn the config into the single source of truth

Authored by ervin on Oct 3 2019, 4:10 PM.



The module had a somewhat convoluted logic around the management of its
settings. Sometimes it was reading through Plasma::Theme (mostly
proxying in some form what was in the config), sometimes straight from
KConfig. We now got rid of m_defaultTheme to avoid the temptation of
reading from it, KConfig is our only source of settings.

We kept a single call to Plasma::Theme on save, but that's simply to
ensure proper signalling of the change to the running shell.

Diff Detail

R119 Plasma Desktop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
ervin created this revision.Oct 3 2019, 4:10 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 3 2019, 4:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ervin requested review of this revision.Oct 3 2019, 4:10 PM
mart accepted this revision.Oct 3 2019, 4:31 PM

I investigated a bit where m_defaultTheme comes from. It seems it goes all way back to the old plasma4 version of the kcm, where Theme was a singleton.
now there is no need whatsoever for that anymore.

This revision is now accepted and ready to land.Oct 3 2019, 4:31 PM
ervin updated this revision to Diff 67302.Oct 4 2019, 8:16 AM

Add missing copyright header change

mart accepted this revision.Oct 4 2019, 8:17 AM
This revision was automatically updated to reflect the committed changes.