Differential D24352

Fix focus HFR-averaging bug
ClosedPublic
Actions

Authored by murveit on Oct 1 2019, 9:12 PM.

Details

Reviewers
mutlaqja
Commits
R321:faec39c2d1e1: Fix focus HFR-averaging bug
Summary

Code intended to remove HFR values that were 2-sigma away from the mean HFR when using the full-field focus algorithm.
However, std::remove_if was not used correctly, and this resulted in a no-op--nothing removed from the HFR mean
calculations. This fixes that issue, and will remove the HFR values > 2-sigma from the HFR mean in the HFR-mean calculation.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
murveit created this revision.Oct 1 2019, 9:12 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptOct 1 2019, 9:12 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
murveit requested review of this revision.Oct 1 2019, 9:12 PM
mutlaqja accepted this revision.Oct 2 2019, 5:43 AM
This revision is now accepted and ready to land.Oct 2 2019, 5:43 AM
Closed by commit R321:faec39c2d1e1: Fix focus HFR-averaging bug (authored by murveit, committed by mutlaqja). · Explain WhyOct 2 2019, 6:31 AM
This revision was automatically updated to reflect the committed changes.
TallFurryMan added a subscriber: TallFurryMan.Oct 2 2019, 6:22 PM

Good spot, I had missed this. But wouldn't it have been clearer to std::erase the result of each std::remove_if? This would have avoided the num_remaining gymnastics.

Revision Contents
Changeset List

PathPackages
Mkstars/fitsviewer/fitsdata.cpp (9 lines)

Diff 67163

View Options

kstars/fitsviewer/fitsdata.cpp

Loading...