Code intended to remove HFR values that were 2-sigma away from the mean HFR when using the full-field focus algorithm.
However, std::remove_if was not used correctly, and this resulted in a no-op--nothing removed from the HFR mean
calculations. This fixes that issue, and will remove the HFR values > 2-sigma from the HFR mean in the HFR-mean calculation.
Details
Details
- Reviewers
mutlaqja - Commits
- R321:faec39c2d1e1: Fix focus HFR-averaging bug
Diff Detail
Diff Detail
- Repository
- R321 KStars
- Branch
- focus-hfr-mean-bug (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 17227 Build 17245: arc lint + arc unit
Comment Actions
Good spot, I had missed this. But wouldn't it have been clearer to std::erase the result of each std::remove_if? This would have avoided the num_remaining gymnastics.