Don't trigger modifier only shortcuts if pointer interaction
ClosedPublic

Authored by graesslin on Aug 13 2016, 1:26 PM.

Details

Summary

If the user clicked a pointer button or scrolled a pointer axis the
held modifier was most likely intended to modify the pointer event.
Thus the modifier only shortcut should not be triggered.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 5894.Aug 13 2016, 1:26 PM
graesslin retitled this revision from to Don't trigger modifier only shortcuts if pointer interaction.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptAug 13 2016, 1:26 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
mart accepted this revision.Aug 14 2016, 9:16 AM
mart added a reviewer: mart.
mart added a subscriber: mart.

This reminds me... That could implement the old mouse gestures used to be done by kglobalaccel?

This revision is now accepted and ready to land.Aug 14 2016, 9:16 AM
In D2435#45529, @mart wrote:

This reminds me... That could implement the old mouse gestures used to be done by kglobalaccel?

The one's from khotkeys? Yeah we could implement those in KWin, though I'm not convinced they make much sense.

This revision was automatically updated to reflect the committed changes.