Fix missing setDefaultShortcuts call
ClosedPublic

Authored by hallas on Oct 1 2019, 3:27 PM.

Details

Summary

The commit eec49bc38f4e256b66bf16ee5428c5f5d7e97e25 cased a warning to
be emitted when starting Dolphin:

KXMLGUIFactoryPrivate::saveDefaultActionProperties(): Shortcut for action "go_forward" "&Forward" set with QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s) instead.

The fix is to call
actionCollection()->setDefaultShortcuts(m_forwardAction, m_forwardAction->shortcuts());
so that the default shortcuts are setup.

Diff Detail

Repository
R318 Dolphin
Branch
fix_missing_set_default_shortcuts
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17216
Build 17234: arc lint + arc unit
hallas created this revision.Oct 1 2019, 3:27 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptOct 1 2019, 3:27 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
hallas requested review of this revision.Oct 1 2019, 3:27 PM
This revision is now accepted and ready to land.Oct 1 2019, 8:14 PM
hallas closed this revision.Oct 3 2019, 3:40 AM