Differential D24334

Rename geometry property to frameGeometry
ClosedPublic
Actions

Authored by zzag on Oct 1 2019, 12:58 PM.

Details

Reviewers

None

Group Reviewers

KWin

Commits

R108:7d4471eba634: Rename geometry property to frameGeometry

Summary

In order to properly implement xdg_surface.set_window_geometry we need
two kinds of geometry - frame and buffer. The frame geometry specifies
visible bounds of the client on the screen, excluding client-side drop
shadows. The buffer geometry specifies rectangle on the screen that the
attached buffer or x11 pixmap occupies on the screen.

This change renames the geometry property to frameGeometry in order to
reflect the new meaning assigned to it as well to make it easier to
differentiate between frame geometry and buffer geometry in the future.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zzag created this revision.Oct 1 2019, 12:58 PM

Restricted Application added a project: KWin. · View Herald TranscriptOct 1 2019, 12:58 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Oct 1 2019, 12:58 PM

Harbormaster completed remote builds in B17206: Diff 67126.Oct 1 2019, 12:58 PM

zzag added a dependency: D24332: [wayland] Get rid of some code duplication in XdgShellClient constructors.Oct 1 2019, 12:58 PM

zzag added a dependent revision: D24335: Fix coding style issues in window packing code.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 2 2019, 9:40 AM

Closed by commit R108:7d4471eba634: Rename geometry property to frameGeometry (authored by zzag). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			abstract_client.h (10 lines)
M			abstract_client.cpp (30 lines)
M			activation.cpp (2 lines)
M			autotests/integration/decoration_input_test.cpp (58 lines)
M			autotests/integration/desktop_window_x11_test.cpp (2 lines)
M			autotests/integration/dont_crash_aurorae_destroy_deco.cpp (2 lines)
M			autotests/integration/dont_crash_cursor_physical_size_empty.cpp (2 lines)
M			autotests/integration/dont_crash_empty_deco.cpp (4 lines)
M			autotests/integration/effects/minimize_animation_test.cpp (4 lines)
M			autotests/integration/effects/translucency_test.cpp (2 lines)
M			autotests/integration/input_stacking_order.cpp (2 lines)
M			autotests/integration/internal_window.cpp (12 lines)
M			autotests/integration/lockscreen.cpp (18 lines)
M			autotests/integration/maximize_test.cpp (8 lines)
M			autotests/integration/move_resize_window_test.cpp (66 lines)
M			autotests/integration/placement_test.cpp (6 lines)
M			autotests/integration/plasma_surface_test.cpp (14 lines)
M			autotests/integration/plasmawindow_test.cpp (10 lines)
M			autotests/integration/pointer_constraints_test.cpp (38 lines)
M			autotests/integration/pointer_input.cpp (80 lines)
M			autotests/integration/quick_tiling_test.cpp (52 lines)
M			autotests/integration/scene_qpainter_test.cpp (2 lines)
M			autotests/integration/screenedge_client_show_test.cpp (6 lines)
M			autotests/integration/shade_test.cpp (6 lines)
M			autotests/integration/struts_test.cpp (24 lines)
M			autotests/integration/touch_input_test.cpp (2 lines)
M			autotests/integration/transient_placement.cpp (14 lines)
M			autotests/integration/window_selection_test.cpp (28 lines)
M			autotests/integration/xdgshellclient_rules_test.cpp (12 lines)
M			autotests/integration/xdgshellclient_test.cpp (24 lines)
M			autotests/integration/xwayland_input_test.cpp (6 lines)
M			autotests/mock_abstract_client.h (6 lines)
M			autotests/mock_abstract_client.cpp (10 lines)
M			autotests/test_screen_edges.cpp (14 lines)
M			effects.cpp (4 lines)
M			events.cpp (20 lines)
M			geometry.cpp (136 lines)
M			input.cpp (4 lines)
M			internal_client.h (4 lines)
M			internal_client.cpp (26 lines)
M			layers.cpp (4 lines)
M			manage.cpp (2 lines)
M			placement.cpp (88 lines)
M			plugins/scenes/opengl/scene_opengl.cpp (2 lines)
M			plugins/scenes/qpainter/scene_qpainter.cpp (4 lines)
M			rules.cpp (2 lines)
M			scene.h (2 lines)
M			screenedge.cpp (4 lines)
M			shadow.cpp (6 lines)
M			toplevel.h (24 lines)
M			toplevel.cpp (8 lines)
M			useractions.cpp (12 lines)
M			workspace.cpp (2 lines)
M			x11client.h (4 lines)
M			x11client.cpp (12 lines)
M			xdgshellclient.h (4 lines)
M			xdgshellclient.cpp (45 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	67126	8c88cea		Oct 1 2019, 12:58 PM	★	★
Diff 2	67174	45784b7	R108:7d4471eba63428b71659c9d5cb5df79ca4a8696a	Oct 2 2019, 8:46 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
3cfa02e43a12	d1da5eec3143	8c88ceaf7314	Vlad Zahorodnii	Rename geometry property to frameGeometry (Show More…)	Sep 27 2019, 10:01 AM

Status	Author	Revision
Closed	zzag	D24338 Document some geometry properties
Closed	zzag	D24336 Don't compute frame extents in packPositionFoo methods
Closed	zzag	D24335 Fix coding style issues in window packing code
Closed	zzag	D24334 Rename geometry property to frameGeometry
Closed	zzag	D24332 [wayland] Get rid of some code duplication in XdgShellClient constructors
Closed	zzag	D24331 [wayland] Fix some coding style issues in setGeometry method
Closed	zzag	D24330 [wayland] Add missing const qualifier in resizeWithChecks
Closed	zzag	D24329 [wayland] Use setGeometry in resizeWithChecks
Closed	zzag	D24328 [wayland] Process pending state and map the client on commit

Rename geometry property to frameGeometryClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 67174

abstract_client.h

abstract_client.cpp

activation.cpp

autotests/integration/decoration_input_test.cpp

autotests/integration/desktop_window_x11_test.cpp

autotests/integration/dont_crash_aurorae_destroy_deco.cpp

autotests/integration/dont_crash_cursor_physical_size_empty.cpp

autotests/integration/dont_crash_empty_deco.cpp

autotests/integration/effects/minimize_animation_test.cpp

autotests/integration/effects/translucency_test.cpp

autotests/integration/input_stacking_order.cpp

autotests/integration/internal_window.cpp

autotests/integration/lockscreen.cpp

autotests/integration/maximize_test.cpp

autotests/integration/move_resize_window_test.cpp

autotests/integration/placement_test.cpp

autotests/integration/plasma_surface_test.cpp

autotests/integration/plasmawindow_test.cpp

autotests/integration/pointer_constraints_test.cpp

autotests/integration/pointer_input.cpp

autotests/integration/quick_tiling_test.cpp

autotests/integration/scene_qpainter_test.cpp

autotests/integration/screenedge_client_show_test.cpp

autotests/integration/shade_test.cpp

autotests/integration/struts_test.cpp

autotests/integration/touch_input_test.cpp

autotests/integration/transient_placement.cpp

autotests/integration/window_selection_test.cpp

autotests/integration/xdgshellclient_rules_test.cpp

autotests/integration/xdgshellclient_test.cpp

autotests/integration/xwayland_input_test.cpp

autotests/mock_abstract_client.h

autotests/mock_abstract_client.cpp

autotests/test_screen_edges.cpp

effects.cpp

events.cpp

geometry.cpp

input.cpp

internal_client.h

internal_client.cpp

layers.cpp

manage.cpp

placement.cpp

plugins/scenes/opengl/scene_opengl.cpp

plugins/scenes/qpainter/scene_qpainter.cpp

rules.cpp

scene.h

screenedge.cpp

shadow.cpp

toplevel.h

toplevel.cpp

useractions.cpp

workspace.cpp

x11client.h

x11client.cpp

xdgshellclient.h

xdgshellclient.cpp

Rename geometry property to frameGeometry
ClosedPublic
Actions

Revision Contents
Changeset List