[wayland] Use setGeometry in resizeWithChecks
ClosedPublic
Actions

Authored by zzag on Oct 1 2019, 8:34 AM.

Details

Reviewers

None

Group Reviewers

KWin

Commits

Summary

Configure xdg-toplevel only through setGeometry method, so it's easier
to reason about how geometry is handled in XdgShellClient.

Repository

R108 KWin

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 17195
Build 17213: arc lint + arc unit

Restricted Application added a project: KWin. · View Herald TranscriptOct 1 2019, 8:34 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Oct 1 2019, 8:34 AM

zzag edited the summary of this revision. (Show Details)Oct 1 2019, 8:41 AM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 2 2019, 9:40 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			xdgshellclient.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	67106	6ac5b8c		Oct 1 2019, 8:34 AM	★	★
Diff 2	67170	84de8d1	R108:7c3d014f21a7ed19030c8c0f41104e87d492f9d6	Oct 2 2019, 8:28 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
e627a014cce9	7ec00aef706e	6ac5b8ca5f1e	Vlad Zahorodnii	[wayland] Use setGeometry in resizeWithChecks (Show More…)	Sep 26 2019, 3:11 PM

Status	Author	Revision
Closed	zzag	D24338 Document some geometry properties
Closed	zzag	D24336 Don't compute frame extents in packPositionFoo methods
Closed	zzag	D24335 Fix coding style issues in window packing code
Closed	zzag	D24334 Rename geometry property to frameGeometry
Closed	zzag	D24332 [wayland] Get rid of some code duplication in XdgShellClient constructors
Closed	zzag	D24331 [wayland] Fix some coding style issues in setGeometry method
Closed	zzag	D24330 [wayland] Add missing const qualifier in resizeWithChecks
Closed	zzag	D24329 [wayland] Use setGeometry in resizeWithChecks
Closed	zzag	D24328 [wayland] Process pending state and map the client on commit