Differential D24310

Fix comparison typo
ClosedPublic
Actions

Authored by barchiesi on Sep 30 2019, 12:39 PM.

Details

Reviewers
dvratil
Commits
R477:aa6679a3843b: Fix comparison typo
Summary

The useDomainAdminAccess and transferOwnership PermissionModifyJob parameters weren't being applied correctly due to an error in the comparison with the request default value (extra negation).

Diff Detail

Repository
R477 KGAPI Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
barchiesi created this revision.Sep 30 2019, 12:39 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptSep 30 2019, 12:39 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
barchiesi requested review of this revision.Sep 30 2019, 12:39 PM
barchiesi added a reviewer: dvratil.Sep 30 2019, 12:39 PM
barchiesi added a project: LibKGAPI.
barchiesi added a subscriber: LibKGAPI.
dvratil accepted this revision.Oct 1 2019, 11:32 AM

Well spotted! Thanks

This revision is now accepted and ready to land.Oct 1 2019, 11:32 AM
Closed by commit R477:aa6679a3843b: Fix comparison typo (authored by barchiesi). · Explain WhyOct 1 2019, 11:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/drive/permissionmodifyjob.cpp (4 lines)

Diff 67119

View Options

src/drive/permissionmodifyjob.cpp

Loading...