Differential D24308

[DataProtocol] compile without implicit coversion from ascii
ClosedPublic
Actions

Authored by ahmadsamir on Sep 30 2019, 11:59 AM.

Details

Reviewers
dfaure
Commits
R241:3b98d91436f5: [DataProtocol] compile without implicit coversion from ascii
Test Plan

make && ctest

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Sep 30 2019, 11:59 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 30 2019, 11:59 AM
ahmadsamir requested review of this revision.Sep 30 2019, 11:59 AM
dfaure requested changes to this revision.Oct 1 2019, 9:50 AM
dfaure added inline comments.
src/core/dataprotocol.cpp
121

It would be faster to keep a QByteArray here and just compare to ' ' and possibly \t.

195

Better remove both QLatin1Char and just compare chars.

205

Same here, and more that follow

This revision now requires changes to proceed.Oct 1 2019, 9:50 AM
ahmadsamir updated this revision to Diff 67125.Oct 1 2019, 12:58 PM

Make it faster by comparing char's directly

dfaure accepted this revision.Oct 2 2019, 8:20 AM
This revision is now accepted and ready to land.Oct 2 2019, 8:20 AM
Closed by commit R241:3b98d91436f5: [DataProtocol] compile without implicit coversion from ascii (authored by ahmadsamir). · Explain WhyOct 4 2019, 3:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/dataprotocol.cpp (21 lines)

Diff 67327

View Options

src/core/dataprotocol.cpp

Loading...