Differential D24302

Ignore Reply-To when replying to your own messages
ClosedPublic
Actions

Authored by gjditchfield on Sep 29 2019, 9:15 PM.

Details

Reviewers
knauss
Commits
R94:c42d6ef2dbab: Ignore Reply-To when replying to your own messages
Summary

If you reply to an email that you sent to someone else, the ReplySmart
strategy sends a reply from yourself to the previous recipients, since
you probably intended to create a follow-up to the original.

However, ReplySmart should ignore any Reply-To header in the original;
otherwise it sends the reply back to yourself.

The first of the new test cases tests this situation. The second new
test shows that the code changes did not break Reply-To handling for
original messages that came from a mailing list.

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gjditchfield created this revision.Sep 29 2019, 9:15 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptSep 29 2019, 9:15 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
gjditchfield requested review of this revision.Sep 29 2019, 9:15 PM
knauss accepted this revision.Sep 30 2019, 2:32 PM
knauss added a subscriber: knauss.

It took me a while to understand, what you want to solve. I also needed to read some documentation to those mail headers:

https://tools.ietf.org/html/rfc2076
https://tools.ietf.org/html/rfc2369
https://cr.yp.to/proto/replyto.html
this suggest, that we should also support Mail-Reply-To, if reply-to-author is used.

I would appreciate, if you can rewrite your commit message to make it more easy to understand other than the commit message I'm fine with the patch.

Did you seen https://www.leptonite.org/mft/software.html?

Here my approach to have a better commit message:

If you reply to an email, that is sent by yourself, the replySmart, needs to ignore Reply-To header, otherwise it sends an email back to yourself.
This is not what you intend, when you reply to a mail sent by yourself you normally expect to create a followup and send a mail from yourself to the previous recipients.

To follow the best practice, we should use the order Mail-Followup-To, Reply-To and afterwards From. For more inforation look at https://cr.yp.to/proto/replyto.html.

This revision is now accepted and ready to land.Sep 30 2019, 2:32 PM
gjditchfield edited the summary of this revision. (Show Details)Sep 30 2019, 8:28 PM
gjditchfield added a comment.Sep 30 2019, 8:32 PM

I agree that KMail should support Mail-Reply-To, and it is on my to-do list.

Closed by commit R94:c42d6ef2dbab: Ignore Reply-To when replying to your own messages (authored by gjditchfield). · Explain WhySep 30 2019, 10:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 67091

View Options

messagecomposer/autotests/replystrategytest.cpp

Loading...
View Options

messagecomposer/src/helper/messagefactoryng.cpp

Loading...