Right click to undo last path point.
ClosedPublic
Actions

Authored by abrahams on Aug 14 2015, 1:41 AM.

Details

Reviewers

dkazakov
rempt

Commits

R8:32bfa8e26257: Right click to undo last path point.
R37:48135195e4b2: Right click to undo last path point.

Summary

The path tool and select path tool will install an event filter to inctercept right click events and right double click events.

Diff Detail

Repository

R8 Calligra

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

abrahams updated this revision to Diff 550.Aug 14 2015, 1:41 AM

abrahams retitled this revision from to Right click to undo last path point..

abrahams updated this object.

abrahams edited the test plan for this revision. (Show Details)

abrahams added reviewers: dkazakov, rempt.

The impetus for this was the magnetic lasso tool. It would be straightforward to extend the right click interface to KoCreatePathTool. (Currently KoCreatePathTool maps both right click and shift-click to end the path without connecting last point.)

How about adding this functionality directly to KoCreatePathTool. Then it will have the same functionality in all applications.

Add right click behavior to KoCreatePathTool

In D243#4352, @zachmann wrote:

How about adding this functionality directly to KoCreatePathTool. Then it will have the same functionality in all applications.

Done. Krita still needs a workaround because it doesn't pass right clicks to the tool by default.

I'm happy with this version.

This revision is now accepted and ready to land.Aug 17 2015, 7:31 AM

Closed by commit R8:32bfa8e26257: Right click to undo last path point. (authored by abrahams). · Explain WhyAug 18 2015, 5:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			krita/plugins/tools/defaulttools/kis_tool_path.h (2 lines)
M			krita/plugins/tools/defaulttools/kis_tool_path.cc (15 lines)
M			krita/plugins/tools/selectiontools/kis_tool_select_path.h (2 lines)
M			krita/plugins/tools/selectiontools/kis_tool_select_path.cc (14 lines)
M			krita/ui/tool/kis_delegated_tool.h (12 lines)
M			libs/basicflakes/tools/KoCreatePathTool.h (1 line)
M			libs/basicflakes/tools/KoCreatePathTool.cpp (27 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	550	67e8669		Aug 14 2015, 1:41 AM	★	★
Diff 2	551	67e8669	Add right click behavior to KoCreatePathTool	Aug 14 2015, 1:58 PM	★	★
Diff 3	579	8a450ef	Commit rCALLIGRA32bfa8e26257cf3126ab68a8c4b22033bce97fda	Aug 18 2015, 5:48 PM	★	★