Differential D24298

Rename getShadow method to updateShadow
ClosedPublic
Actions

Authored by zzag on Sep 29 2019, 11:33 AM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Commits

R108:99d318594964: Rename getShadow method to updateShadow

Summary

getShadow is not a getter method as it doesn't return a shadow.

Test Plan

Compiles.

Diff Detail

Repository

Branch

drop-hasshadow-method

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 17150
Build 17168: arc lint + arc unit

zzag created this revision.Sep 29 2019, 11:33 AM

Restricted Application added a project: KWin. · View Herald TranscriptSep 29 2019, 11:33 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Sep 29 2019, 11:33 AM

Harbormaster completed remote builds in B17150: Diff 67027.Sep 29 2019, 11:33 AM

romangg accepted this revision.Sep 29 2019, 12:22 PM

This revision is now accepted and ready to land.Sep 29 2019, 12:22 PM

Closed by commit R108:99d318594964: Rename getShadow method to updateShadow (authored by zzag). · Explain WhySep 29 2019, 1:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			composite.cpp (8 lines)
M			events.cpp (2 lines)
M			internal_client.cpp (4 lines)
M			scene.cpp (2 lines)
M			shadow.cpp (12 lines)
M			toplevel.h (2 lines)
M			toplevel.cpp (2 lines)
M			x11client.cpp (4 lines)
M			xdgshellclient.cpp (8 lines)

Diff 67027

composite.cpp

Loading...

events.cpp

Loading...

internal_client.cpp

Loading...

scene.cpp

Loading...

shadow.cpp

Loading...

toplevel.h

Loading...

toplevel.cpp

Loading...

x11client.cpp

Loading...

xdgshellclient.cpp

Loading...