Differential D24296

Fix alternative translation path building
ClosedPublic
Actions

Authored by adrianchavesfernandez on Sep 29 2019, 10:03 AM.

Tags

None

Subscribers

Details

Reviewers

None

Group Reviewers

Commits

R456:ab20f9318e59: Fix alternative translation path building

Summary

BUG: 316924

Test Plan

Tested manually

Diff Detail

Repository

Branch

fix-alternative-translation-load

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17409
Build 17427: arc lint + arc unit

adrianchavesfernandez requested review of this revision.Sep 29 2019, 10:03 AM

adrianchavesfernandez created this revision.

Harbormaster completed remote builds in B17147: Diff 67024.Sep 29 2019, 10:03 AM

adrianchavesfernandez added a reviewer: Localization.Sep 29 2019, 10:03 AM

adrianchavesfernandez removed a reviewer: Localization.

adrianchavesfernandez added a reviewer: Localization.

adrianchavesfernandez added a subscriber: Localization.

adrianchavesfernandez removed a subscriber: Localization.

can we please use + like normal people?

We already have QT_USE_QSTRINGBUILDER which turns the + into % anyway

Use + instead of %

Harbormaster completed remote builds in B17409: Diff 67447.Oct 7 2019, 5:31 PM

not really convinced about projectDir+poBaseDir thought.

Would poDir() only make more sense?

Yeah, that works as well and it is indeed much cleaner.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 19 2019, 2:25 PM

Closed by commit R456:ab20f9318e59: Fix alternative translation path building (authored by adrianchavesfernandez). · Explain Why

This revision was automatically updated to reflect the committed changes.

adrianchavesfernandez added a comment.Oct 19 2019, 2:25 PM

This comment was removed by adrianchavesfernandez.

Revision Contents
Changeset List

			Path	Packages
M			src/alttransview.cpp (2 lines)

Diff 67447

src/alttransview.cpp

Loading...