Differential D24289

Fix wrong KCM device icon for specific form factors
ClosedPublic
Actions

Authored by sefaeyeoglu on Sep 28 2019, 7:17 PM.

Details

Reviewers
ngraham
GB_2
Group Reviewers
VDG
Plasma
Commits
R115:5f6b290728a8: Fix wrong KCM device icon for specific form factors
Summary

The KCM did not know how different form factors should be displayed. The applet uses a functiun in "icon.js" to find out which icon to use. I have ported this over to the KCM.

Related: D24161

Test Plan

Connect phone via Bluetooth and play music.

Now: "phone" icon appears

Before: "audio-card" icon appears,

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sefaeyeoglu created this revision.Sep 28 2019, 7:17 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 28 2019, 7:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sefaeyeoglu requested review of this revision.Sep 28 2019, 7:17 PM
sefaeyeoglu edited the test plan for this revision. (Show Details)Sep 28 2019, 7:20 PM
ngraham accepted this revision.Sep 30 2019, 4:15 PM
This revision is now accepted and ready to land.Sep 30 2019, 4:15 PM
Closed by commit R115:5f6b290728a8: Fix wrong KCM device icon for specific form factors (authored by sefaeyeoglu, committed by ngraham). · Explain WhySep 30 2019, 4:15 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Sep 30 2019, 4:17 PM

I notice that the Bluetooth applet has the same icon issues. I wonder if we should put this function in plasma-framework so it can be used by lots of other things without having to duplicate it multiple times.

Revision Contents
Changeset List

Diff 67073

View Options

src/kcm/package/contents/code/icon.js

Loading...
View Options

src/kcm/package/contents/ui/DeviceListItem.qml

Loading...