Differential D24273

Use colorful icon for "Profiles" in settings window sidebar
ClosedPublic
Actions

Authored by ngraham on Sep 27 2019, 8:45 PM.

Details

Reviewers
GB_2
Group Reviewers
VDG
Konsole
Maniphest Tasks
T10165: Large category icons should all be colorful
Commits
R319:a6136dd80f3d: Use colorful icon for "Profiles" in settings window sidebar
Summary

This is in support of T10165 specifically, and Goal: Consistency more generally.

The chosen colorful icon for the Profiles page isn't perfect, but I think it's better
than what's there right now.

Test Plan

Before:


After:

Diff Detail

Repository
R319 Konsole
Branch
use-all-colorful-icons-in-settings-sidebar (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17176
Build 17194: arc lint + arc unit
ngraham created this revision.Sep 27 2019, 8:45 PM
Restricted Application added a project: Konsole. · View Herald TranscriptSep 27 2019, 8:45 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
ngraham requested review of this revision.Sep 27 2019, 8:45 PM
ngraham added a task: T10165: Large category icons should all be colorful.Sep 27 2019, 8:46 PM

I know Konsole has moved to GitLab, but I did this on Phab because that way it integrates nicely with the phab task tracking the overarching issue. Hope that's okay.

GB_2 added a subscriber: GB_2.Sep 27 2019, 8:59 PM
GB_2 added inline comments.
src/MainWindow.cpp
776

While at it, maybe also make this folder-temp.

ndavis added a subscriber: ndavis.Sep 27 2019, 9:00 PM

the users icon doesn't seem quite right

ngraham added a comment.Sep 27 2019, 9:17 PM
In D24273#538944, @ndavis wrote:

the users icon doesn't seem quite right

It was the best I could find, but feel free to suggest a better one. Or maybe we need a new icon.

ngraham updated this revision to Diff 66973.Sep 27 2019, 9:17 PM

Also use folder-temp for the temporary files icon, which makes more sense

ngraham marked an inline comment as done.Sep 27 2019, 9:18 PM
ngraham edited the summary of this revision. (Show Details)
ndavis added a comment.Sep 28 2019, 5:56 PM

maybe instead of the users icon, use preferences-system-profiles? it would fallback to preferences-system until the icon is created.

ngraham updated this revision to Diff 67072.Sep 30 2019, 3:37 PM

Use preferences-system-profiles for now

ngraham edited the test plan for this revision. (Show Details)Sep 30 2019, 3:37 PM
GB_2 accepted this revision.Sep 30 2019, 4:16 PM
This revision is now accepted and ready to land.Sep 30 2019, 4:16 PM
ngraham closed this revision.Sep 30 2019, 4:18 PM

Revision Contents
Changeset List

PathPackages
Msrc/MainWindow.cpp (4 lines)

Diff 67072

View Options

src/MainWindow.cpp

Loading...