inserting the tracks not at the end fix the bug
detected by QAbstractItemModelTester which is really a nice tool
BUG: 406466
Details
Details
- Reviewers
ngraham astippich jguidon - Group Reviewers
Elisa - Commits
- R255:cccafdff17a3: insert album tracks at the correct place instead of at the end
new test is OK, no regressions
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Branch
- fixPlayListInsertAlbum
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 17107 Build 17125: arc lint + arc unit
Comment Actions
This fixes the bug for me when navigating to an artist and clicking on the Add to Playlist or Replace and Play buttons in the toolbar. But it is still broken for the following other use cases:
- Navigate to a genre and click on the Add to Playlist or Replace and Play buttons in the toolbar
- Click on the Add to Playlist or Replace and Play buttons in the grid delegate for an artist or a genre
It appears that buttons in the grid delegates trigger different logic than the toolbar buttons, which is probably something that should be unified.