[Style KCM] Don't explicitly reload KWin's configuration
ClosedPublic

Authored by broulik on Sep 27 2019, 1:18 PM.

Details

Summary

This was only done for changes to the "effects", not the actual widget style, but:

  • plasma-integration updates ShowIconsOnPushButtons and ShowIconsInMenuItems when a change to SETTINGS_STYLE is notified by the KCM
  • plasma-integration updates toolbar style when ToolbarStyleChanged is notified by the KCM
Test Plan
  • Disabled icons on menus, decoration menu icons were gone immediately
  • Don't know where KWin actually has a dialog with buttons or toolbars

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Sep 27 2019, 1:18 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 27 2019, 1:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sep 27 2019, 1:18 PM
broulik edited the summary of this revision. (Show Details)

I had a look through kwin and kdecoration

There's 5 or so things that fetch things from qstyle directly, but nothing seems to cache the value, with the exception of:
effects/startupfeedback/startupfeedback.cpp: cursorSize = QApplication::style()->pixelMetric(QStyle::PM_LargeIconSize);

You could probably make a compelling case that this one thing doesn't matter

You could probably make a compelling case that this one thing doesn't matter

It doesn't matter because we don't signal KWin when we change the style, only when changing the "effects" settings (toolbar style, show icons on buttons and in menus), so the pixel metric isn't affected by this at all.

davidedmundson accepted this revision.Sep 29 2019, 1:14 PM
This revision is now accepted and ready to land.Sep 29 2019, 1:14 PM
This revision was automatically updated to reflect the committed changes.