Enable the auto-stretch Fits setting to be undone.
AbandonedPublic

Authored by murveit on Sep 27 2019, 2:23 AM.

Details

Reviewers
mutlaqja
Summary

Previously, when the Kstars Fits setting AutoStretch was set, and the image
was displayed in the viewer, the stretch could not be undone. This change
allows undo of the initial stretch with the undo button. A follow-in might
convert the autostretch button to toggle stretch if no intermediate filter
was applied.

Diff Detail

Repository
R321 KStars
Branch
undo-stretch (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17080
Build 17098: arc lint + arc unit
murveit created this revision.Sep 27 2019, 2:23 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptSep 27 2019, 2:23 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
murveit requested review of this revision.Sep 27 2019, 2:23 AM

Though why would this be required since the user expect autostretch by default if that option was checked? It might lead to some confusion to "undo" operation since they didn't do anything.

I agree it's not a perfect UI. I do think it is nice have the ability to see the unstretched image.

Personally, I like to mostly see the stretched image (so I set the autostretch setting) but occasionally want to see if my stars are badly blown out.
My thought was that this was a possible way to do it.
I believe that people will get it--if they see the image go unstretched right after they hit undo.

We could, as I said in the comment, also turn the stretch button into a "undo only if auto0-stretch is on top of the undo stack", otherwise stretch.

Anyway, your call. Why don't you try it for a few days?
Hy

I still think this will lead to confusion. I think another option is to have some option in view menu to show "raw image" or unstretched image or whatever and that would do what you want.

OK, I'll take a look at it and come back to you with a proposal or code-review.

Should this be revised after the other changes were merged?

This is out-of-date, I guess abandoned, and the new scheme is an improvement, IMHO.
Is there something I need to do to delete/abandon it?

Hy

mutlaqja resigned from this revision.Nov 27 2019, 7:39 AM
murveit abandoned this revision.May 4 2020, 3:46 AM