| zzag |
| KWin |
Qt's metaobject is rather sensitive with scope resolution.
Foo::Bar and Bar don't always match to a Qt metaobject, even if they
refer to the same thing to a compiler. Here we register
X11Compositor::SuspendReason but Q_ARG uses SuspendReason and they don't
match. This leads to a runtime failure where the method isn't invoked.
Rather than fixing metaobject usage, port the whole thing to lambdas
which does better compile time checking and is generally nicer to read.
BUG: 412353
Ran xprop to block compositing. Compositing was blocked.
Grepped source code for Q_ARG use
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| composite.cpp | ||
|---|---|---|
| 1016–1019 | It'll be more compact with QTimer::singleShot. QTimer::singleShot(0, this, [this]() { suspend(BlockRuleSuspend); }); I don't have strong opinion about this though. | |
| composite.cpp | ||
|---|---|---|
| 1016–1019 | Yeah, I typically use QTimer out of habit, though I've seen comments saying to use QMetaObject for semantic reasons. They end up being exactly the same thing, I don't think either is better or worse. | |