Differential D24237

Fix compilation with Qt 5.14
ClosedPublic
Actions

Authored by dfaure on Sep 26 2019, 9:18 AM.

Details

Reviewers
dvratil
Commits
R477:e4ef79c38490: Fix compilation with Qt 5.14
Summary

Use Q_NAMESPACE_EXPORT as recommended by the Qt 5.14 changelog,
the previous code was abusing the definition of Q_NAMESPACE.

cmake doesn't yet know that it should run moc on files that contain
Q_NAMESPACE_EXPORT, working on upstream patch

Test Plan

Builds

Diff Detail

Repository
R477 KGAPI Library
Branch
Applications/19.08
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17043
Build 17061: arc lint + arc unit
dfaure created this revision.Sep 26 2019, 9:18 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptSep 26 2019, 9:18 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dfaure requested review of this revision.Sep 26 2019, 9:18 AM
dvratil accepted this revision.Sep 26 2019, 10:16 AM
This revision is now accepted and ready to land.Sep 26 2019, 10:16 AM
dfaure closed this revision.Sep 26 2019, 2:26 PM
dfaure added a comment.Sep 27 2019, 1:26 AM

For the record, the upstream fix proposal is https://codereview.qt-project.org/c/qt/qtbase/+/275380 (Qt is actually a better place than cmake for this)

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (1 line)
Msrc/calendar/CMakeLists.txt (1 line)
Msrc/calendar/enums.h (4 lines)

Diff 66875

View Options

CMakeLists.txt

Loading...
View Options

src/calendar/CMakeLists.txt

Loading...
View Options

src/calendar/enums.h

Loading...