These changes add the ability to set the payee's city and state
ClosedPublic
Actions

Authored by philhopkins on Sep 26 2019, 3:28 AM.

Details

Reviewers

Commits

R261:98ac8a23aeb4: These changes add the ability to set the payee's city and state
R261:b6bf258a80a9: These changes add the ability to set the payee's city and state

Summary

I revomed the lines that Thomas flagged. After testing I found that they were not necessary. Also I checked and now all of the fields in the XML and SQL database are able to be edited and changed with this patch.

IS there a way that this patch can be reviewed and landed?

Diff Detail

Repository

R261 KMyMoney

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17055
Build 17073: arc lint + arc unit

philhopkins requested review of this revision.Sep 26 2019, 3:28 AM

philhopkins created this revision.

Harbormaster completed remote builds in B17034: Diff 66862.Sep 26 2019, 3:28 AM

tbaumgart mentioned this in T11777: add ability to set payee city and payee state.Sep 26 2019, 5:29 AM

tbaumgart added a reviewer: tbaumgart.

Other than that, it seems fine. I have not run any of that yet.

kmymoney/views/kpayeesview.cpp
490–491	Don't know, if we need those here. We do have the city and state in their own input fields now. This would enter them twice into the payee, or am I missing something?

This revision now requires changes to proceed.Sep 26 2019, 11:32 AM

Removig superfluous lines in kpayeesview.cpp

Harbormaster completed remote builds in B17055: Diff 66901.Sep 26 2019, 4:09 PM

philhopkins edited the summary of this revision. (Show Details)Sep 26 2019, 4:12 PM

philhopkins edited the summary of this revision. (Show Details)Oct 29 2019, 3:03 AM

Looks good to me.

This revision is now accepted and ready to land.Nov 1 2019, 2:18 PM

Closed by commit R261:98ac8a23aeb4: These changes add the ability to set the payee's city and state (authored by tbaumgart). · Explain WhyJan 30 2020, 9:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kmymoney/mymoney/mymoneycontact.h (2 lines)
M			kmymoney/views/kpayeesview.cpp (22 lines)
M			kmymoney/views/kpayeesview.ui (66 lines)
M			kmymoney/views/kpayeesview_p.h (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	66862	8325e56		Sep 26 2019, 3:28 AM	★	★
Diff 2	66901	8325e56	Removig superfluous lines in kpayeesview.cpp	Sep 26 2019, 4:09 PM	★	★
Diff 3	74729	ac15c36	R261:98ac8a23aeb474340e8236ba8557da447051923e	Jan 30 2020, 9:00 PM	★	★