Make *DefaultMessageColor use semantically correct colorscheme colors
ClosedPublic

Authored by ndavis on Sep 25 2019, 4:30 PM.

Details

Summary

The unread message color was changed to ActiveText and the important message color was changed to NeutralText.

After looking at the documentation in the KColorScheme header file, it seemed to me that ActiveText and NeutralText were more appropriate than Complementary FocusColor and NegativeText. ActiveText is appropriate for new items and Neutral Text is appropriate for warnings. Obviously, I can't use ActiveText for both and NegativeText is for errors, which important messages are not, so I used NeutralText for important messages.

This currently results in almost no visual changes except for unread messages being a slightly brighter shade of blue and important messages being orange. In the future, I will change ActiveText in the Breeze colorscheme to yellow.

Test Plan

old


new

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Sep 25 2019, 4:30 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptSep 25 2019, 4:30 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
ndavis requested review of this revision.Sep 25 2019, 4:30 PM

Please show a screenshot about before/after as it was changed because it was too difficult to important message.

ndavis edited the test plan for this revision. (Show Details)Sep 25 2019, 7:27 PM
ndavis edited the test plan for this revision. (Show Details)

Please show a screenshot about before/after as it was changed because it was too difficult to important message.

Done

ngraham accepted this revision.Sep 25 2019, 11:52 PM
ngraham added a subscriber: ngraham.

Absolutely better. We should never use the red color for something that isn't destructive simply to draw attention to it.

This revision is now accepted and ready to land.Sep 25 2019, 11:52 PM
mlaurent accepted this revision.Sep 26 2019, 5:20 AM

Ok it seems that we can see information. Thanks.

This revision was automatically updated to reflect the committed changes.