[platforms/drm] Consider DSI connector type to be internal display
ClosedPublic

Authored by bshah on Sep 25 2019, 6:42 AM.

Details

Summary

Lot of mobile devices, as well as tablet devices use the DSI connector,
for internal screens. This is more common in ARM devices, so consider
them as internal display as well.

Test Plan

checked on the device with DSI screen, it was considered internal

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bshah created this revision.Sep 25 2019, 6:42 AM
Restricted Application added a project: KWin. · View Herald TranscriptSep 25 2019, 6:42 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
bshah requested review of this revision.Sep 25 2019, 6:42 AM
bshah added a comment.Sep 25 2019, 6:51 AM

This bit is mostly unused apart from the orientation sensor enabling, but nevertheless, I want to commit this to Plasma/5.17 branch (to make it easier for me to test rotation patch further on some of target devices)

Just quickly checking Wikipedia it shows an image of the RPi display connector. In such cases it's not an internal one. Is this just an outlier and we can ignore it? Or is there a second condition we can AND it with?

bshah added a comment.Sep 25 2019, 7:43 AM

Raspberry-PI usecase is slightly weird, but apart from that almost all of the mobile and ARM tablet devices uses MIPI DSI connector. So not really no, you can't make it much more specific.

bshah added a comment.Sep 25 2019, 7:46 AM

What I meant by raspberry-pi usecase being weird is, if you have external case for raspberry pi and connect display then it is "internal" in a way. I am not entirely sure what definition of internal we are following here.

If it is case of, is display hot-plugged? then no, DSI connector doesn't allow hotplug.

romangg accepted this revision.Sep 25 2019, 7:56 AM

I am not entirely sure what definition of internal we are following here.

I don't know either. Current definition via connector type rubs me a bit wrong but haven't looked into it yet more if there is a better criteria. Anyway let's get it merged then.

This revision is now accepted and ready to land.Sep 25 2019, 7:56 AM
This revision was automatically updated to reflect the committed changes.