Add settings change listener
ClosedPublic

Authored by broulik on Sep 24 2019, 7:43 PM.

Details

Summary

I found it's on chrome.storage and not chrome.storage.sync. This also works with Firefox now.
Also removes the need to have the options page explicitly send a signal that settings changed.

Test Plan
  • Changed some settings, had them sent to the host just fine. Both on Firefox 69 and Chrome 77

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 24 2019, 7:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 24 2019, 7:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sep 24 2019, 7:43 PM
fvogt accepted this revision.Sep 26 2019, 3:15 PM

Seems to work on FF ESR

This revision is now accepted and ready to land.Sep 26 2019, 3:15 PM
This revision was automatically updated to reflect the committed changes.