Let plugin add additional status information
ClosedPublic

Authored by broulik on Sep 24 2019, 2:03 PM.

Details

Summary

This can be used to communicate further status information, e.g. whether an external dependency or binary was found.

Test Plan

Will be used in the future for checking whether the itinerary extractor is installed. The plugin might be supported in the host just fine but the extractor might not be installed.

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 24 2019, 2:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 24 2019, 2:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sep 24 2019, 2:03 PM
broulik added inline comments.
host/abstractbrowserplugin.h
47

Not too happy about making it public, but it is used by Settings. Other alternative would be to make a getter in PluginManager which then calls this... or also making Settings a friend class

fvogt accepted this revision.Sep 24 2019, 2:06 PM

Seems a bit weird to merge it at the top-level instead of adding a new key, but it's unlikely to result in abuse.

This revision is now accepted and ready to land.Sep 24 2019, 2:06 PM
fvogt added inline comments.Sep 24 2019, 2:07 PM
host/abstractbrowserplugin.h
47

I actually expect a method like this to be public

This revision was automatically updated to reflect the committed changes.