FEATURE: 412260
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- walk_through_media (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 16946 Build 16964: arc lint + arc unit
Comment Actions
+1 for the desired end goal, but I have some implementation concerns:
| applets/mediacontroller/contents/ui/ExpandedRepresentation.qml | ||
|---|---|---|
| 121 | Why W? W for Walk? Seems kind of arbitrary; "walk" isn't really a word I would associate with this. In any event this seems like the kind of thing that would benefit from being a global shortcut rather than something that only works when the applet is open and has focus. | |
| applets/mediacontroller/contents/ui/main.qml | ||
| 252 | Why wouldn't you want to be able to do this when there are two sources? | |
| applets/mediacontroller/contents/ui/ExpandedRepresentation.qml | ||
|---|---|---|
| 121 | I agree with your judgement on this. I will look into how I can change this. | |
| applets/mediacontroller/contents/ui/main.qml | ||
| 252 | mpris2Source.sources always has at least one value, that value being "@multiplex". Because of this it will have a length of 3 when there are two audio sources, a length of 4 when there are three, etc. Perhaps I should include a comment to clarify and avoid this confusion. | |