Differential D24162

Hide "Lock Widgets" button from panel edit mode toolbar
ClosedPublic
Actions

Authored by GB_2 on Sep 23 2019, 3:53 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Maniphest Tasks
T10402: Find a way to remove the Desktop Toolbox in its current form (i.e. a hamburger menu button in the corner of the screen)
T11094: Improve discoverability of widget configuration
T10190: (Re)define modes when editing panels and widgets
Commits
R119:88bce0e49c7e: Hide "Lock Widgets" button from panel edit mode toolbar
Summary

In D24839 we hide "Lock Widgets" from the UI, so do the same thing here.

BUG: 412433

Test Plan

Open the panel edit mode.

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17995
Build 18013: arc lint + arc unit
GB_2 created this revision.Sep 23 2019, 3:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 23 2019, 3:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Sep 23 2019, 3:53 PM
ngraham accepted this revision.Sep 26 2019, 5:31 PM
This revision is now accepted and ready to land.Sep 26 2019, 5:31 PM
ngraham edited the summary of this revision. (Show Details)Oct 7 2019, 1:23 AM
GB_2 edited the summary of this revision. (Show Details)Oct 21 2019, 5:58 PM
ngraham added a comment.Oct 21 2019, 6:54 PM

Needs a rebase

GB_2 updated this revision to Diff 68476.Oct 21 2019, 7:05 PM

Rebase

ngraham added a comment.Oct 21 2019, 7:12 PM

The Edit Panel menu item probably shouldn't be visible while that panel is currently being edited:

GB_2 added a comment.Oct 21 2019, 7:13 PM
In D24162#551671, @ngraham wrote:

The Edit Panel menu item probably shouldn't be visible while that panel is currently being edited:

Unrelated ;-)

ngraham added a comment.Oct 21 2019, 7:14 PM

Oh, so that would need to be done in D24839 then?

GB_2 added a comment.Oct 21 2019, 7:16 PM
In D24162#551673, @ngraham wrote:

Oh, so that would need to be done in D24839 then?

That would need to be a new patch IMO.

ngraham accepted this revision.Oct 21 2019, 7:18 PM

All right.

Closed by commit R119:88bce0e49c7e: Hide "Lock Widgets" button from panel edit mode toolbar (authored by GB_2). · Explain WhyOct 29 2019, 5:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 68476

View Options

desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml

Loading...