Don't require QtGui for the PaginateModel test
ClosedPublic

Authored by leinir on Sep 23 2019, 12:36 PM.

Details

Summary

This is done by switching from the QStandardItemModel, which requires
QtGui, to QStringListModel, which is in QtCore. The result is a much
leaner test, and it's all done by adding a couple of helper functions
which add the simplistic data addition functions from QSIM, except
locked to QStrings (the way it was being used anyway).

Test Plan

Run the tests, which still pass

Diff Detail

Repository
R134 Discover Software Store
Branch
dont-require-qtgui-for-paginatemodel-test (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16907
Build 16925: arc lint + arc unit
leinir created this revision.Sep 23 2019, 12:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 23 2019, 12:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
leinir requested review of this revision.Sep 23 2019, 12:36 PM
apol accepted this revision.Oct 1 2019, 10:17 AM

I'm not sure what we're winning, but sure.

This revision is now accepted and ready to land.Oct 1 2019, 10:17 AM
In D24156#540238, @apol wrote:

I'm not sure what we're winning, but sure.

It allows the tests to be run on e.g. postmarketOS' CI - https://gitlab.com/postmarketOS/pmaports/merge_requests/639#note_220402081 shows the specific problem :) (there's other issues, as seen in the comments further down from there, but yeah, it's really just a "why require gui when we don't need it" sort of situation... especially when the fix is as simple as this :) )

This revision was automatically updated to reflect the committed changes.