I am not sure how much this is the right solution, because I am not familiar with js at a sufficient level. But having considered all the solutions, I realized that this is one of the simplest solutions. I can’t explain correctly, so I’ll give an example. The user enters a number, say "102.03200". In memory, this will be stored as 10203200 and 5. That is, to get the number back we need 10203200/10 ^ 5. Ok. Only integers are involved in the calculations. A fraction is added only at the output stage.
Diff Detail
- Repository
- R114 Plasma Addons
- Branch
- calculatorApplet (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 17063 Build 17081: arc lint + arc unit
- This needs more explanation in the Description section to indicate why the proposed change is a good idea.
- This seems like it has some unrelated changes in it, which look worthwhile, but they should be in a separate patch. Is this fixing https://bugs.kde.org/show_bug.cgi?id=410988?
- I am not sure where the description window is.
- Yes, this fixes this bug. I am not sure how much this is the right solution, because I am not familiar with js at a sufficient level. But having considered all the solutions, I realized that this is one of the simplest solutions. I can’t explain correctly, so I’ll give an example. The user enters a number, say "102.03200". In memory, this will be stored as 10203200 and 5. That is, to get the number back we need 10203200/10 ^ 5.
It also fixes a bug with the display of numbers. And the "C" button does the same as the "AC", because before that, when I clicked on "C" and further calculations, the answer was incorrect or the "C" button seemed not obvious to me.
You can click on the Edit Revision button to add stuff to the description.
- Yes, this fixes this bug. I am not sure how much this is the right solution, because I am not familiar with js at a sufficient level. But having considered all the solutions, I realized that this is one of the simplest solutions. I can’t explain correctly, so I’ll give an example. The user enters a number, say "102.03200". In memory, this will be stored as 10203200 and 5. That is, to get the number back we need 10203200/10 ^ 5. It also fixes a bug with the display of numbers. And the "C" button does the same as the "AC", because before that, when I clicked on "C" and further calculations, the answer was incorrect or the "C" button seemed not obvious to me.
Excellent. Could you split this out so we have two patches:
- One that fixes https://bugs.kde.org/show_bug.cgi?id=410988
- Another one (this one?) that makes C do the same thing as AC
Make a second patch that only fixes the bug, and then remove those changes from this patch.
Do I need to create another page with only bug fix? Or do I need to make another commit only with bug fix? What to do with the correction of the display of numbers?Because I need the changes that are in the fixed bug.
If there are three changes necessary (fix display, fix bug, change C behavior) then we need three patches in a dependency chain. :) See https://community.kde.org/Infrastructure/Phabricator#If_the_patches_are_all_for_the_same_project