Refactor add-bugzilla-versions into a Bash script that runs a Python package
ClosedPublic

Authored by adrianchavesfernandez on Sep 21 2019, 2:35 PM.

Details

Summary

I created a python package at tools/python-kde-release, included a Bash script helper to run commands from the Python package (including transparently creating or updating a virtual environment), and created an add_bugzilla_versions.sh Bash script in the root of this repository that uses the helper Bash script to run the corresponding Python method.

If the approach seems OK to everyone, I can proceed to do the same with the appstream script, and implement proper code sharing in the process.

Test Plan

I manually tested add_bugzilla_version.sh with --dry.

Diff Detail

Repository
R497 Release tools
Branch
python-refactoring
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16868
Build 16886: arc lint + arc unit
adrianchavesfernandez requested review of this revision.Sep 21 2019, 2:35 PM
adrianchavesfernandez created this revision.
aacid added a comment.Sep 22 2019, 3:37 PM

So the benefit of this is that one doesn't need to install the dependencies manually but they will automagically be installed?

Yes, that is the most immediate benefit. Using a Python package also makes it cleaner to share code later.

aacid accepted this revision.Sep 23 2019, 9:25 PM

ok, let's go for it i guess then.

Do you have commit access or shall i?

This revision is now accepted and ready to land.Sep 23 2019, 9:25 PM

Merged into the add-appstream-version branch.