[GTK3] Fix menu bugs
ClosedPublic

Authored by cblack on Sep 20 2019, 10:38 PM.

Details

Summary

GtkMenus no longer have a curved highlight. Additionally, checkboxes in menus now apply the user's colorscheme properly.

Test Plan

Menu, before:


Menu, after:

Checkboxes before:

Checkboxes after:

Diff Detail

Repository
R98 Breeze for Gtk
Branch
fix-menu-curve (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16849
Build 16867: arc lint + arc unit
cblack created this revision.Sep 20 2019, 10:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 20 2019, 10:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Sep 20 2019, 10:38 PM
cblack retitled this revision from [GTK3] Fix menu highlights being curved to [GTK3] Fix menu bugs.Sep 20 2019, 10:42 PM
cblack edited the summary of this revision. (Show Details)
cblack edited the test plan for this revision. (Show Details)
ngraham accepted this revision.Sep 20 2019, 11:40 PM
ngraham added a subscriber: ngraham.

Does this fix https://bugs.kde.org/show_bug.cgi?id=412078? I can't reproduce it myself so I can't tell.

This revision is now accepted and ready to land.Sep 20 2019, 11:40 PM
This revision was automatically updated to reflect the committed changes.

Does this fix https://bugs.kde.org/show_bug.cgi?id=412078? I can't reproduce it myself so I can't tell.

This patch doesn't touch any of the style nodes that would be affecting that bug.

Which patch does fix https://bugs.kde.org/show_bug.cgi?id=412078 then? It was listed as one of the fixed bugs in your original combined-together patch.