Differential D24118

Fix KDE Connect package on macOS
ClosedPublic
Actions

Authored by Inoki on Sep 20 2019, 5:29 PM.

Details

Reviewers
vonreth
albertvaka
Group Reviewers
KDE Connect
Summary

Since the rename of kdeconnect qml app to 'kdeconnect-app', craft can no longer find kdeconnect qml app executable and copy it

Diff Detail

Repository
R877 Craft Blueprints for KDE
Lint
Lint Skipped
Unit
Unit Tests Skipped
Inoki requested review of this revision.Sep 20 2019, 5:29 PM
Inoki created this revision.
vonreth added a comment.Sep 20 2019, 5:52 PM

hm the bundle name looks ugly....

Inoki added a comment.Sep 20 2019, 5:59 PM
In D24118#535345, @vonreth wrote:

hm the bundle name looks ugly....

Agree, but it does have such name, lol
https://invent.kde.org/kde/kdeconnect-kde/blob/master/app/CMakeLists.txt

sredman added a subscriber: sredman.Sep 21 2019, 1:20 AM

Does kdeconnect.app have to be renamed to kdeconnect-app.app? Can it just stay with the old name?
( I guess I don't know what that part does. If it's not user-visible then I don't think it matters)

albertvaka accepted this revision.Sep 21 2019, 1:25 AM
This revision is now accepted and ready to land.Sep 21 2019, 1:25 AM
apol added a subscriber: apol.Oct 1 2019, 10:09 AM

Wasn't this landed?

Inoki added a comment.Oct 1 2019, 5:42 PM
In D24118#540236, @apol wrote:

Wasn't this landed?

Landed right now.

I reinstalled the OS and forgot adding the new ssh key...lol

Inoki closed this revision.Oct 1 2019, 6:08 PM

Revision Contents
Changeset List

Diff 66555

View Options

extragear/kdeconnect-kde/kdeconnect-kde.py

Loading...