Differential D24101

[GTK3] Improve button appearance
ClosedPublic
Actions

Authored by cblack on Sep 19 2019, 10:02 PM.

Details

Reviewers
ngraham
Group Reviewers
Breeze
Commits
R98:712bba9acadb: Merge branch 'Plasma/5.17' - keyboard focus bugfix
R98:22637c221ee3: [GTK3] Improve button appearance
Summary

Buttons now have more vertical padding and now indicate if they have keyboard focus.

BUG: 370425
FIXED-IN: 5.17

Test Plan

Before:


After:

Diff Detail

Repository
R98 Breeze for Gtk
Branch
button-fixes (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16814
Build 16832: arc lint + arc unit
cblack created this revision.Sep 19 2019, 10:02 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 19 2019, 10:02 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Sep 19 2019, 10:02 PM
cblack edited the test plan for this revision. (Show Details)Sep 19 2019, 10:04 PM
cblack edited the summary of this revision. (Show Details)
ngraham added a subscriber: ngraham.Sep 19 2019, 10:13 PM

The focus changes are definitely a bugfix, likely this whole patch is 5.17 material. Will review later!

ngraham accepted this revision.Sep 20 2019, 2:36 AM

5.17 and merge to master please.

This revision is now accepted and ready to land.Sep 20 2019, 2:36 AM
ngraham edited the summary of this revision. (Show Details)Sep 20 2019, 2:36 AM
Closed by commit R98:22637c221ee3: [GTK3] Improve button appearance (authored by cblack). · Explain WhySep 20 2019, 2:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/gtk3/widgets/_button.scss (24 lines)

Diff 66511

View Options

src/gtk3/widgets/_button.scss

Loading...