Update Color KCM
ClosedPublic
Actions

Authored by ochurlaud on Aug 11 2016, 3:04 PM.

Details

Reviewers

andreask
mart
bshah

Group Reviewers

VDG
Plasma

Summary

As discussed with the VDG, the color KCM had to be split in a very simple KCM to choose a color scheme, and a color scheme editor.

What is here?

I rewrote/refactor almost all the code so that it's easier to understand (hopefully).
I created a standalone app to edit.

Here are the current issues:

I reuse the headers/cpp files of the standalone app in the kcm. It would be better to directly call the app, but then I don't know how to repopulate the list when I'm done with the app (see in KColorCm::on_schemeEditButton_clicked)

~~The standalone app has not a correct name (How should I call the executable and the app?)~~

~~The standalone app doesn't have all the KAboutData + CommandParser things, because I'm a little lazy.~~

To test directly, you can use the branch andreas/kcm_update

Screenshots

The new KCM

When Edit scheme is clicked (and the standalone app is the dialog only)

Diff Detail

Repository

R119 Plasma Desktop

Lint

Lint Skipped

Unit

Unit Tests Skipped

ochurlaud updated this revision to Diff 5837.Aug 11 2016, 3:04 PM

ochurlaud retitled this revision from to Update Color KCM.

ochurlaud updated this object.

ochurlaud edited the test plan for this revision. (Show Details)

ochurlaud added reviewers: Plasma, mart, andreask, VDG.

ochurlaud set the repository for this revision to R119 Plasma Desktop.

Restricted Application added a project: Plasma. · View Herald TranscriptAug 11 2016, 3:04 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Thanks Oliver,

can you post some screenshots cause I can't compile it.

In D2409#45025, @andreaska wrote:

Thanks Oliver,

can you post some screenshots cause I can't compile it.

Updated

The KCM looks okay for a first iteration, although for the future, it would make more sense to design it like the Look And Feel or Desktop Theme KCMs, with a grid of bigger previews instead of list + one big preview.
What I'd change right now is Config Scheme -> Edit Scheme

For the editor app: The biggest problem is that it still looks and feels like a KCM or a config dialog, not like a proper application. That is okay for the first iteration, but in the future, it should be turned into a proper application layout (with a classical top toolbar, more spacing etc).

as a name, what about the whoefully uninspiring kcolorschemeeditor? :)

I would like it in plasma-sdk. even keeping it there for a while is fine, it's just important that it's shipped when the new kcm is in, to not have a release with feature loss

I like it. Nice work. I agree I would change Config Scheme to Edit Scheme.

In D2409#45058, @whiting wrote:

I like it. Nice work. I agree I would change Config Scheme to Edit Scheme.

Done locally.

The executable is now KColorSchemeEditor.

If someone could tell me what the kcolorschemeditor.desktop should be as well? Then I'll update the review.

Added a desktop file, finished the app (KAboutData, CommandLineParser,...)

Ready to ship, I just wait for your remarks.

ochurlaud updated this object.Aug 15 2016, 10:46 AM

bshah accepted this revision.Aug 15 2016, 11:18 AM

bshah added a reviewer: bshah.

This revision is now accepted and ready to land.Aug 15 2016, 11:18 AM

bshah commandeered this revision.Aug 15 2016, 11:18 AM

bshah edited reviewers, added: ochurlaud; removed: bshah.

This revision now requires review to proceed.Aug 15 2016, 11:18 AM

This has been submitted, I will just abandon changes..

ochurlaud commandeered this revision.Aug 15 2016, 11:21 AM

ochurlaud reclaimed this revision.

ochurlaud edited reviewers, added: bshah; removed: ochurlaud.

bshah accepted this revision.Aug 15 2016, 11:22 AM

bshah edited edge metadata.

This revision is now accepted and ready to land.Aug 15 2016, 11:22 AM

This was submitted in commit b9e2664cc7aa50aa9e6be8368f34390bc756b73a

Revision Contents
Changeset List

		Path
M		kcms/colors/CMakeLists.txt (54 lines)
M		kcms/colors/colorscm.h (188 lines)
M		kcms/colors/colorscm.cpp (1319 lines)
M		kcms/colors/colorsettings.ui (1279 lines)
A	M	kcms/colors/schemeeditor.cpp (46 lines)
A	M	kcms/colors/scmeditorcolors.h (121 lines)
A	M	kcms/colors/scmeditorcolors.cpp (519 lines)
A	M	kcms/colors/scmeditorcolors.ui (437 lines)
A	M	kcms/colors/scmeditordialog.h (81 lines)
A	M	kcms/colors/scmeditordialog.cpp (231 lines)
A	M	kcms/colors/scmeditordialog.ui (74 lines)
A	M	kcms/colors/scmeditoreffects.h (68 lines)
A	M	kcms/colors/scmeditoreffects.cpp (186 lines)
A	M	kcms/colors/scmeditoreffects.ui (268 lines)
A	M	kcms/colors/scmeditoroptions.h (67 lines)
A	M	kcms/colors/scmeditoroptions.cpp (101 lines)
A	M	kcms/colors/scmeditoroptions.ui (120 lines)