Add benchmark for Parser
ClosedPublic

Authored by dfaure on Sep 19 2019, 5:39 PM.

Details

Summary

Will be useful for future optimization work

Diff Detail

Branch
2019_09_benchmark
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16803
Build 16821: arc lint + arc unit
dfaure requested review of this revision.Sep 19 2019, 5:39 PM
dfaure created this revision.
dfaure updated this revision to Diff 66498.Sep 19 2019, 7:11 PM

Print out stats so we can find out if parser is completely broken

Wait until finished signal rather than relying on ThreadWeaver to cleanup
on early app exit.

mwolff accepted this revision.EditedSep 20 2019, 4:41 AM

better use stdout/stderr "directly" instead of going through qDebug which could be disabled in a release build

tests/benchmarks/bench_parser.cpp
22

QTextStream

36

QTextStream(stdout) << ...

This revision is now accepted and ready to land.Sep 20 2019, 4:41 AM

How about I just remove the output altogether now that there is a unittest for Parser?

dfaure closed this revision.Sep 20 2019, 4:22 PM