Differential D24086

Don't initialize QFlags<T> with nullptr
ClosedPublic
Actions

Authored by zzag on Sep 19 2019, 3:19 PM.

Details

Reviewers
romangg
Group Reviewers
KWin
Commits
R108:b8a6fd7c4678: Don't initialize QFlags<T> with nullptr
Summary

This looks very odd.

Test Plan

Compiles.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Sep 19 2019, 3:19 PM
Restricted Application added a project: KWin. · View Herald TranscriptSep 19 2019, 3:19 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Sep 19 2019, 3:19 PM
apol added a subscriber: apol.Sep 19 2019, 3:33 PM
apol added inline comments.
kcmkwin/kwinrules/ruleswidget.cpp
590

maybe using {} reads better?

zzag updated this revision to Diff 66479.Sep 19 2019, 4:02 PM

apol's suggestion.

romangg accepted this revision.Sep 19 2019, 6:19 PM
This revision is now accepted and ready to land.Sep 19 2019, 6:19 PM
Closed by commit R108:b8a6fd7c4678: Don't initialize QFlags<T> with nullptr (authored by zzag). · Explain WhySep 19 2019, 6:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 66497

View Options

client.cpp

Loading...
View Options

effects/desktopgrid/desktopgrid_config.cpp

Loading...
View Options

effects/trackmouse/trackmouse.cpp

Loading...
View Options

events.cpp

Loading...
View Options

geometry.cpp

Loading...
View Options

group.cpp

Loading...
View Options

kcmkwin/kwinrules/ruleswidget.cpp

Loading...
View Options

manage.cpp

Loading...
View Options

utils.cpp

Loading...