Cleanup and modernize the Calendar library codebase
ClosedPublic
Actions

Authored by dvratil on Sep 19 2019, 3:12 PM.

Details

Reviewers

barchiesi

Commits

Summary

enable C++14
use QScopedPointer for d-pointers
remove dead/unused code
refactor duplicated code into functions
use named constants instead of string literals to avoid typos but also to reduce the binary size due to string duplication
const'ify and auto'ify

Test Plan

Compiles, tests pass

Repository

R477 KGAPI Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

dvratil requested review of this revision.Sep 19 2019, 3:12 PM

This patch is an excellent example that can be used in other parts of LibKGAPI. I couldn't find anything to point out, it is good for me.

This revision is now accepted and ready to land.Sep 21 2019, 3:05 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (2 lines)
M			src/calendar/calendar.h (3 lines)
M			src/calendar/calendar.cpp (29 lines)
M			src/calendar/calendarcreatejob.h (6 lines)
M			src/calendar/calendarcreatejob.cpp (19 lines)
M			src/calendar/calendardeletejob.h (4 lines)
M			src/calendar/calendardeletejob.cpp (16 lines)
M			src/calendar/calendarfetchjob.h (4 lines)
M			src/calendar/calendarfetchjob.cpp (42 lines)
M			src/calendar/calendarmodifyjob.h (6 lines)
M			src/calendar/calendarmodifyjob.cpp (18 lines)
M			src/calendar/calendarservice.h (9 lines)
M			src/calendar/calendarservice.cpp (983 lines)
M			src/calendar/event.h (6 lines)
M			src/calendar/event.cpp (33 lines)
M			src/calendar/eventcreatejob.h (4 lines)
M			src/calendar/eventcreatejob.cpp (17 lines)
M			src/calendar/eventdeletejob.h (4 lines)
M			src/calendar/eventdeletejob.cpp (16 lines)
M			src/calendar/eventfetchjob.h (4 lines)
M			src/calendar/eventfetchjob.cpp (51 lines)
M			src/calendar/eventmodifyjob.h (4 lines)
M			src/calendar/eventmodifyjob.cpp (17 lines)
M			src/calendar/eventmovejob.h (4 lines)
M			src/calendar/eventmovejob.cpp (60 lines)
M			src/calendar/freebusyqueryjob.h (9 lines)
M			src/calendar/freebusyqueryjob.cpp (12 lines)
M			src/calendar/reminder.h (16 lines)
M			src/calendar/reminder.cpp (39 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	66469	4455efe		Sep 19 2019, 3:12 PM	★	★
Diff 2	66471	4455efe	* Missing const in the timezone lookup tables	Sep 19 2019, 3:18 PM	★	★
Diff 3	66611	5028258	R477:cf2065e10062b0e562adbe3a61680b5fd11df83c	Sep 22 2019, 11:33 AM	★	★