Differential D24083

Add name to Reservation
AbandonedPublic
Actions

Authored by broulik on Sep 19 2019, 1:31 PM.

Details

Reviewers
vkrause
Summary

It seems to be used as the name of the reservation action?!

Test Plan

See also D24082

Very odd.

"potentialAction": [
    {
        "@type": "ReserveAction",
        "result": {
            "@type": "FoodEstablishmentReservation",
            "name": "Reserve a table" // ???
        },
        "target": "https://somereservationsite"
    }
]

Diff Detail

Repository
R1003 KItinerary: Travel Reservation handling library
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Sep 19 2019, 1:31 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptSep 19 2019, 1:31 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
broulik requested review of this revision.Sep 19 2019, 1:31 PM
vkrause added a comment.Sep 19 2019, 1:34 PM

Are you consuming this in PBI in that format? Or should we rather normalize this to Action::name during input?

broulik added a comment.EditedSep 19 2019, 1:38 PM

Are you consuming this in PBI in that format?

I was wondering whether I should, currently I do. "Prenota un tavolo" might not mean much to a non-Italian, though.
However, I think another consumer could just check for "ReservationAction" and ignore the name.
It surely tries saving me from walking back the chain to see "ok, this is a reservation action for... a restaurant" and then show the appropriate "reserve a table" text.

broulik abandoned this revision.May 29 2020, 7:14 AM

Let's revisit that should it ever come up again :)

Revision Contents
Changeset List

Diff 66460

View Options

src/datatypes/reservation.h

Loading...
View Options

src/datatypes/reservation.cpp

Loading...