Differential D24075

[kcmkwin/compositing] Hide animation speed slider on Plasma
ClosedPublic
Actions

Authored by davidedmundson on Sep 19 2019, 1:04 PM.

Details

Reviewers

zzag

Maniphest Tasks

T11315: Global Animation Slider

Commits

R108:a486b471e1a4: [kcmkwin/compositing] Hide animation speed slider on Plasma

Summary

Hide the animation speed slider on Plasma as this becomes duplicated
with the global "animation speed" slider.

Also port to the new format for the config option which stores the
actual multiplier, not a magic number.

Test Plan

Didn't appear normally
Manually modified env; slider appeared
Tested load/save of defaults and the two extremes

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson created this revision.Sep 19 2019, 1:04 PM

Restricted Application added a project: KWin. · View Herald TranscriptSep 19 2019, 1:04 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

davidedmundson requested review of this revision.Sep 19 2019, 1:04 PM

Harbormaster completed remote builds in B16774: Diff 66451.Sep 19 2019, 1:04 PM

davidedmundson added a dependent revision: D24084: Migrate kwin animation speed to kdeglobals.Sep 19 2019, 1:48 PM

zzag added a subscriber: zzag.Sep 19 2019, 3:50 PM

zzag added inline comments.

kcmkwin/kwincompositing/compositing.cpp
377	Style: `{` goes on the next line.
kcmkwin/kwincompositing/main.cpp
32	Where is it used?
33–34	Keep them sorted alphabetically please.
88	Delete qDebug.

update

Harbormaster completed remote builds in B16939: Diff 66714.Sep 23 2019, 8:38 PM

update2

Harbormaster completed remote builds in B16940: Diff 66715.Sep 23 2019, 8:39 PM

davidedmundson marked an inline comment as done.Sep 23 2019, 8:39 PM

zzag accepted this revision.Sep 23 2019, 9:37 PM

zzag added inline comments.

kcmkwin/kwincompositing/compositing.cpp
382	stay new line

This revision is now accepted and ready to land.Sep 23 2019, 9:37 PM

zzag added inline comments.Sep 23 2019, 9:44 PM

kcmkwin/kwincompositing/compositing.cpp
72–75	stray new line

Closed by commit R108:a486b471e1a4: [kcmkwin/compositing] Hide animation speed slider on Plasma (authored by davidedmundson). · Explain WhySep 25 2019, 1:50 PM

This revision was automatically updated to reflect the committed changes.

ngraham added a task: T11315: Global Animation Slider.Sep 26 2019, 7:58 PM

Revision Contents
Changeset List

			Path	Packages
M			kcmkwin/kwincompositing/compositing.h (12 lines)
M			kcmkwin/kwincompositing/compositing.cpp (36 lines)
M			kcmkwin/kwincompositing/compositing.ui (147 lines)
M			kcmkwin/kwincompositing/main.cpp (24 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	66451	5b08ca1		Sep 19 2019, 1:04 PM	★	★
Diff 2	66714	04845b6	update	Sep 23 2019, 8:38 PM	★	★
Diff 3	66715	04845b6	update2	Sep 23 2019, 8:39 PM	★	★
Diff 4	66824	78a66fc	R108:a486b471e1a455b0804c50335e2c2773eca97af9	Sep 25 2019, 1:50 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
c007b8503c31	c70dcfe4f074	04845b60074b	David Edmundson	[kcmkwin/compositing] Hide animation speed slider on Plasma (Show More…)	Sep 23 2019, 8:15 PM

Status	Author	Revision
Closed	davidedmundson	D24084 Migrate kwin animation speed to kdeglobals
Closed	davidedmundson	D22887 Load animation speed from new global animation speed controller
Closed	davidedmundson	D24075 [kcmkwin/compositing] Hide animation speed slider on Plasma