[kcmkwin/compositing] Hide animation speed slider on Plasma
ClosedPublic

Authored by davidedmundson on Sep 19 2019, 1:04 PM.

Details

Summary

Hide the animation speed slider on Plasma as this becomes duplicated
with the global "animation speed" slider.

Also port to the new format for the config option which stores the
actual multiplier, not a magic number.

Test Plan

Didn't appear normally
Manually modified env; slider appeared
Tested load/save of defaults and the two extremes

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Sep 19 2019, 1:04 PM
Restricted Application added a project: KWin. · View Herald TranscriptSep 19 2019, 1:04 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Sep 19 2019, 1:04 PM
zzag added a subscriber: zzag.Sep 19 2019, 3:50 PM
zzag added inline comments.
kcmkwin/kwincompositing/compositing.cpp
377

Style: { goes on the next line.

kcmkwin/kwincompositing/main.cpp
32

Where is it used?

33–34

Keep them sorted alphabetically please.

88

Delete qDebug.

davidedmundson marked 3 inline comments as done.

update

davidedmundson marked an inline comment as done.Mon, Sep 23, 8:39 PM
zzag accepted this revision.Mon, Sep 23, 9:37 PM
zzag added inline comments.
kcmkwin/kwincompositing/compositing.cpp
382

stay new line

This revision is now accepted and ready to land.Mon, Sep 23, 9:37 PM
zzag added inline comments.Mon, Sep 23, 9:44 PM
kcmkwin/kwincompositing/compositing.cpp
72–75

stray new line

This revision was automatically updated to reflect the committed changes.