See D23931
Details
Details
Diff Detail
Diff Detail
- Repository
- R499 Metadata for build scripts
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
The changes were probably rolled back when I synced stable and master to ensure they matched.
Note that the KWayland Integration changes are likely unnecessary - all Frameworks are provided by default to projects outside of frameworks/*
Assuming the same logic holds, and as long as the respective maintainers of KWayland Integration and KWin are still fine with this, it can go in again.
Comment Actions
As far i can it does not hold when building with kde-srcbuild : kwayland-integration was not built when building plasma-desktop or Kwin for instance.
Assuming the same logic holds, and as long as the respective maintainers of KWayland Integration and KWin are still fine with this, it can go in again.
David approved the previous diff, this one juste copies the change to master and stable. https://phabricator.kde.org/D24071#
Comment Actions
Sorry for not being clear - the lines i'm referring to are lines 467 to 469 in your diff - you don't need to mark KWayland Integration as depending on particular Frameworks, because that is done by a global rule.